Mark pub's update_locked_test as flaky.

Mark pub's update_locked_test as flaky.

Committed: https://code.google.com/p/dart/source/detail?r=27008

[floitsch, 2013-09-02 10:42:38]

TBR.

[floitsch, 2013-09-02 10:42:56]

Committed patchset #1 manually as r27008 (presubmit successful).

[floitsch, 2013-09-02 10:45:51]

CCing Nicolas and Anders since they saw the flake earlier and are probably right
now in the process of writing a similar CL.

[kustermann, 2013-09-02 10:46:00]

I'm not sure if this is correct. Peter recently made some changes to unittest to
make tests fail if they don't respond within 20 seconds. If this test is taking
slightly longer this will fail (just because the timeout is too low).

http://build.chromium.org/p/client.dart/builders/pub-win/builds/10572/steps/p...

...
FAILED: none-vm-checked release_ia32 pub/test/update/git/update_locked_test
Expected: pass 
Actual: fail
CommandOutput[vm]:

stdout:
unittest-suite-wait-for-done
ERROR: updates locked Git packages
  Test timed out after 20 seconds.
...

[floitsch, 2013-09-02 10:49:40]

The test ran in 19 secs in the previous run. So this seems likely. I don't know
how to fix this, since there is a FAIL reported to the test-script and not a
TIMEOUT.

[kustermann, 2013-09-02 10:53:36]

On 2013/09/02 10:49:40, floitsch wrote:
> The test ran in 19 secs in the previous run. So this seems likely. I don't
know
> how to fix this, since there is a FAIL reported to the test-script and not a
> TIMEOUT.

Yes, the reason why a fail is reported is that the test itself will report a
fail.
The changes peter made is not in test.dart but rather in unittest.
I *think* the tests can be changed to something like

import "package:unittest/unittest.dart" as unittest;

main() {
  useConfiguration();

  unittest.timeout = const Duration(...);

  test(...)
}