Adapt private variables with trailing underscores.

Adapt private variables with trailing underscores.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27807

[Lasse Reichstein Nielsen, 2013-09-24 07:43:20]

lgtm

https://codereview.chromium.org/23619086/diff/1/runtime/lib/immutable_map.dart
File runtime/lib/immutable_map.dart (right):

https://codereview.chromium.org/23619086/diff/1/runtime/lib/immutable_map.dar...
runtime/lib/immutable_map.dart:15: // search. But is it worth it?
Add a comment here: Yes, it may be worth it if maps a large.

I fully expect users to create const maps that are large and assume constant
time lookup - that how you would build a static table in Dart.
For small maps, by all means make them linear. The limit is likely around 10
elements.

[floitsch, 2013-09-24 11:19:13]

https://codereview.chromium.org/23619086/diff/1/runtime/lib/immutable_map.dart
File runtime/lib/immutable_map.dart (right):

https://codereview.chromium.org/23619086/diff/1/runtime/lib/immutable_map.dar...
runtime/lib/immutable_map.dart:15: // search. But is it worth it?
On 2013/09/24 07:43:21, Lasse Reichstein Nielsen wrote:
> Add a comment here: Yes, it may be worth it if maps a large.
> 
> I fully expect users to create const maps that are large and assume constant
> time lookup - that how you would build a static table in Dart.
> For small maps, by all means make them linear. The limit is likely around 10
> elements.

There is already a TODO. No need to add our expectations.

[floitsch, 2013-09-24 11:20:02]

Committed patchset #3 manually as r27807 (presubmit successful).

[srdjan, 2013-09-25 16:29:58]

lgtm