Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 23619068: pkg/crypto: tighten up (Closed)

Created:
7 years, 3 months ago by kevmoo-old
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/crypto: tighten up Added return types, marked fields as final R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M pkg/crypto/lib/crypto.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/lib/src/hash_utils.dart View 7 chunks +18 lines, -20 lines 0 comments Download
M pkg/crypto/lib/src/hmac.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/crypto/lib/src/sha256.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
7 years, 3 months ago (2013-09-17 20:26:54 UTC) #1
floitsch
LGTM. thanks.
7 years, 3 months ago (2013-09-18 09:35:15 UTC) #2
kevmoo-old
7 years, 3 months ago (2013-09-18 11:09:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698