Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 23619026: Simplify VM internal representation of a mixin application clause (MixinAppType (Closed)

Created:
7 years, 3 months ago by regis
Modified:
7 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify VM internal representation of a mixin application clause (MixinAppType object) by removing some redundant field and type arguments. Tolerate mixins with wrong number of type arguments and update tests. Note: this is a first cleanup step in preparation of more mixin bug fixes. This cl was committed as r27363.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -108 lines) Patch
M runtime/vm/class_finalizer.cc View 3 chunks +25 lines, -28 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +20 lines, -15 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +35 lines, -10 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +31 lines, -37 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -7 lines 0 comments Download
M tests/language/mixin_type_parameters_errors_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
I still need to update the status files for dart2js and friends, since I modified ...
7 years, 3 months ago (2013-09-10 23:38:02 UTC) #1
regis
On 2013/09/10 23:38:02, regis wrote: > I still need to update the status files for ...
7 years, 3 months ago (2013-09-10 23:56:20 UTC) #2
hausner
7 years, 3 months ago (2013-09-11 00:05:23 UTC) #3
Lgtm. Nice cleanup.

Powered by Google App Engine
This is Rietveld 408576698