Add support for passing in vm options to the dart2js scripts.

Add support for passing in vm options to the dart2js scripts.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27690

[ricow1, 2013-09-20 08:09:34]

Updated to allow for multiple arguments.

Additionally, changed the normal array appends to use the ('value) notation

[ahe, 2013-09-20 08:20:23]

LGTM!

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js
File sdk/bin/dart2js (right):

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js#newcode36
sdk/bin/dart2js:36:
EXTRA_OPTIONS[${#EXTRA_OPTIONS[@]}]='--enable-diagnostic-colors'
Could you update this as well?

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js.bat#newcode39
sdk/bin/dart2js.bat:39: if not "%DART_VM_OPTIONS%" == "" (
I'm not sure how this works. I have a suspicion that this would be more robust:

if not _%DART_VM_OPTIONS%_ == __ (

[ricow1, 2013-09-20 08:24:51]

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js
File sdk/bin/dart2js (right):

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js#newcode36
sdk/bin/dart2js:36:
EXTRA_OPTIONS[${#EXTRA_OPTIONS[@]}]='--enable-diagnostic-colors'
On 2013/09/20 08:20:23, ahe wrote:
> Could you update this as well?

Done.

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://codereview.chromium.org/23618063/diff/6001/sdk/bin/dart2js.bat#newcode39
sdk/bin/dart2js.bat:39: if not "%DART_VM_OPTIONS%" == "" (
On 2013/09/20 08:20:23, ahe wrote:
> I'm not sure how this works. I have a suspicion that this would be more
robust:
> 
> if not _%DART_VM_OPTIONS%_ == __ (

Done.

[ricow1, 2013-09-20 08:25:10]

Committed patchset #4 manually as r27690 (presubmit successful).