Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 23618043: dart:typed_data type hierarchy changes try 3 (Closed)

Created:
7 years, 3 months ago by Cutch
Modified:
7 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:typed_data type hierarchy changes try 3 Committed: https://code.google.com/p/dart/source/detail?r=27413

Patch Set 1 #

Patch Set 2 : Fix by adding !nonleaf annotation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 1 2 chunks +19 lines, -1 line 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 3 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib/typed_data/typed_data_hierarchy_int64_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib/typed_data/typed_data_hierarchy_test.dart View 1 1 chunk +62 lines, -0 lines 0 comments Download
M tests/standalone/typed_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Cutch
7 years, 3 months ago (2013-09-11 11:08:08 UTC) #1
sra1
7 years, 3 months ago (2013-09-11 23:05:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r27413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698