Issue 23618008: Suppressing exceptions in Dartium's dart:js usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23618008: Suppressing exceptions in Dartium's dart:js usage (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
terry, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Suppressing exceptions in Dartium's dart:js usage Trying to get code to start up clean with first-chance exceptions. BUG=12548 R=jacobr@google.com, terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=26753

Patch Set 1 : #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	pkg/polymer/lib/polymer_element.dart	View		1 chunk	+4 lines, -6 lines	2 comments	Download
	M	sdk/lib/js/dartium/js_dartium.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/23618008/diff/3001/pkg/polymer/lib/polymer_element.dart File pkg/polymer/lib/polymer_element.dart (right): https://codereview.chromium.org/23618008/diff/3001/pkg/polymer/lib/polymer_element.dart#newcode179 pkg/polymer/lib/polymer_element.dart:179: // Dartium this wouldn't exist. However, dart:js isn't robust ...

7 years, 3 months ago (2013-08-27 20:29:30 UTC) #1

terry

lgtm https://codereview.chromium.org/23618008/diff/3001/pkg/polymer/lib/polymer_element.dart File pkg/polymer/lib/polymer_element.dart (right): https://codereview.chromium.org/23618008/diff/3001/pkg/polymer/lib/polymer_element.dart#newcode186 pkg/polymer/lib/polymer_element.dart:186: return; Nice to eliminate the try/catch.

7 years, 3 months ago (2013-08-27 23:30:08 UTC) #3

blois

7 years, 3 months ago (2013-08-27 23:46:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26753 (presubmit successful).

Expand Messages | Collapse Messages