Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 236133013: Allow the analysis server to connect to the client over stdio. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow the analysis server to connect to the client over stdio. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35095

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M pkg/analysis_server/lib/driver.dart View 3 chunks +5 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/stdio_server.dart View 1 chunk +37 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
Jaime: this change should start to unblock you from implementing the connection from the editor ...
6 years, 8 months ago (2014-04-15 22:03:27 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/236133013/diff/1/pkg/analysis_server/lib/stdio_server.dart File pkg/analysis_server/lib/stdio_server.dart (right): https://codereview.chromium.org/236133013/diff/1/pkg/analysis_server/lib/stdio_server.dart#newcode35 pkg/analysis_server/lib/stdio_server.dart:35: ); nit: the formatting here is rather unfortunate. ...
6 years, 8 months ago (2014-04-15 22:13:16 UTC) #2
Paul Berry
https://codereview.chromium.org/236133013/diff/1/pkg/analysis_server/lib/stdio_server.dart File pkg/analysis_server/lib/stdio_server.dart (right): https://codereview.chromium.org/236133013/diff/1/pkg/analysis_server/lib/stdio_server.dart#newcode35 pkg/analysis_server/lib/stdio_server.dart:35: ); On 2014/04/15 22:13:16, Brian Wilkerson wrote: > nit: ...
6 years, 8 months ago (2014-04-15 22:43:07 UTC) #3
Paul Berry
6 years, 8 months ago (2014-04-15 22:53:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698