Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 23609017: fix dart2js warnings when compiling polymer_expressions (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix dart2js warnings when compiling polymer_expressions it might be a dart2js bug, but I'm not sure the generic adds anything here, so removed it. R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=27267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/polymer_expressions/lib/eval.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer_expressions/lib/visitor.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
the errors looked like: out/ReleaseIA32/packages/polymer_expressions/visitor.dart:29:11: Warning: "ParenthesizedExpression" is not assignable to "E". visit(e);
7 years, 3 months ago (2013-09-06 19:07:01 UTC) #1
justinfagnani
lgtm
7 years, 3 months ago (2013-09-06 19:11:54 UTC) #2
Jennifer Messerly
7 years, 3 months ago (2013-09-06 20:33:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698