Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 236063019: Remove "listening on port $port" message. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove "listening on port $port" message. This prevents it from interfering with stdio-based communication between the editor and analysis server. R=brianwilkerson@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=35107

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-15 23:01:59 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/236063019/diff/1/pkg/analysis_server/lib/http_server.dart File pkg/analysis_server/lib/http_server.dart (right): https://codereview.chromium.org/236063019/diff/1/pkg/analysis_server/lib/http_server.dart#newcode88 pkg/analysis_server/lib/http_server.dart:88: stderr.writeln('Listening on port $port'); Somehow, writing non-error messages ...
6 years, 8 months ago (2014-04-15 23:19:34 UTC) #2
Paul Berry
On 2014/04/15 23:19:34, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/236063019/diff/1/pkg/analysis_server/lib/http_server.dart > File pkg/analysis_server/lib/http_server.dart (right): ...
6 years, 8 months ago (2014-04-15 23:51:47 UTC) #3
jwren
On 2014/04/15 23:51:47, Paul Berry wrote: > On 2014/04/15 23:19:34, Brian Wilkerson wrote: > > ...
6 years, 8 months ago (2014-04-16 00:04:01 UTC) #4
Paul Berry
6 years, 8 months ago (2014-04-16 14:55:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r35107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698