Issue 23606008: Work around VM bug 12963

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23606008: Work around VM bug 12963 (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
5 years, 10 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Work around VM bug 12963 Committed: https://code.google.com/p/dart/source/detail?r=26978

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart	View		1 chunk	+2 lines, -2 lines	1 comment	Download
	M	dart/sdk/lib/_internal/pub/test/update/git/update_one_locked_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r26978 (presubmit successful).

7 years, 3 months ago (2013-08-31 11:41:15 UTC) #2

nweiz

7 years, 3 months ago (2013-09-03 18:25:08 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/23606008/diff/1/dart/sdk/lib/_internal/pub/te...
File
dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart
(right):

https://codereview.chromium.org/23606008/diff/1/dart/sdk/lib/_internal/pub/te...
dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart:9:
import 'package:unittest/unittest.dart' as unittest;
Don't import unittest in a test that uses scheduled_test; import scheduled_test
instead. It re-exports everything from unittest that it wants available,
including unittestConfiguration, and overrides or wraps some things.

Also, we generally don't use "show" unless there's a specific name conflict
we're trying to avoid.

Expand Messages | Collapse Messages