Issue 23602018: Update dart2dart status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23602018: Update dart2dart status (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update dart2dart status Committed: https://code.google.com/p/dart/source/detail?r=26940

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	dart/tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r26940 (presubmit successful).

7 years, 3 months ago (2013-08-30 20:10:23 UTC) #2

ngeoffray

LGTM https://codereview.chromium.org/23602018/diff/1/dart/tests/lib/lib.status File dart/tests/lib/lib.status (right): https://codereview.chromium.org/23602018/diff/1/dart/tests/lib/lib.status#newcode79 dart/tests/lib/lib.status:79: library_metadata2_test/01: Skip # http://dartbug.com/11511 Skip -> Fail ?

7 years, 3 months ago (2013-08-31 14:45:48 UTC) #3

ahe

7 years, 3 months ago (2013-08-31 14:49:46 UTC) #4

Message was sent while issue was closed.

Thanks Nicolas.

https://codereview.chromium.org/23602018/diff/1/dart/tests/lib/lib.status
File dart/tests/lib/lib.status (right):

https://codereview.chromium.org/23602018/diff/1/dart/tests/lib/lib.status#new...
dart/tests/lib/lib.status:79: library_metadata2_test/01: Skip #
http://dartbug.com/11511
On 2013/08/31 14:45:48, ngeoffray wrote:
> Skip -> Fail ?

It should have been covered by the skip statement above.

It is rather random which mirror tests works in dart2dart (especially with
minification), so I decided to ignore dart2dart.

Expand Messages | Collapse Messages