Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 23600020: Native abstract classes may be 'instantiated' (Closed)

Created:
7 years, 3 months ago by sra1
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Native abstract classes may be instantiated as a proxy for undeclared native subclasses. Native classes can have subclasses that are not declared to the program, for example, some browsers have subclasses of HTMLElement that are not present on other browsers. Instances of these subclasses are treated as instances of the known class (HTMLElement). What this means is that abstract native classes can appear to have instances, so abstract native classes can appear to be instantiated. Committed: https://code.google.com/p/dart/source/detail?r=27314

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +6 lines, -1 line 1 comment Download
A tests/compiler/dart2js_native/abstract_class_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
Committed patchset #1 manually as r27314 (presubmit successful).
7 years, 3 months ago (2013-09-09 22:21:49 UTC) #1
sra1
TBR=ngeoffray This fixes issue 12556
7 years, 3 months ago (2013-09-09 22:22:12 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-10 11:55:37 UTC) #3
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/23600020/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/23600020/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:125: || cls.isNative()) {
Could we avoid marking the native classes abstract instead?

Powered by Google App Engine
This is Rietveld 408576698