Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 23600017: Revert "Support dynamic as type literal." (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Support dynamic as type literal." This reverts commit 27285. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/first_class_types_literals_test.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 3 months ago (2013-09-09 14:59:18 UTC) #1
ngeoffray
LGTM
7 years, 3 months ago (2013-09-09 15:02:14 UTC) #2
karlklose
7 years, 3 months ago (2013-09-09 15:03:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698