Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 23599002: Update language status file (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update language status file Add issue numbers. Change a test to not rely on the toString() value if a TypeError. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26764

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -42 lines) Patch
M tests/language/generic_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 7 chunks +32 lines, -35 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-08-27 13:30:22 UTC) #1
kustermann
LGTM with one question. https://chromiumcodereview.appspot.com/23599002/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://chromiumcodereview.appspot.com/23599002/diff/1/tests/language/language_dart2js.status#newcode68 tests/language/language_dart2js.status:68: generic_test: Fail, OK Why is ...
7 years, 3 months ago (2013-08-27 14:19:26 UTC) #2
Søren Gjesse
https://chromiumcodereview.appspot.com/23599002/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://chromiumcodereview.appspot.com/23599002/diff/1/tests/language/language_dart2js.status#newcode68 tests/language/language_dart2js.status:68: generic_test: Fail, OK On 2013/08/27 14:19:26, kustermann wrote: > ...
7 years, 3 months ago (2013-08-28 06:41:22 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-08-28 06:48:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698