Remove usage of dart:json.

Remove usage of dart:json.

R=jmesserly@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26789

[floitsch, 2013-08-27 15:48:52]

Normally this change should not introduce any semantic changes.

[nweiz, 2013-08-27 17:05:01]

Changes to my libraries lgtm

https://codereview.chromium.org/23596007/diff/3001/pkg/yaml/lib/yaml.dart
File pkg/yaml/lib/yaml.dart (right):

https://codereview.chromium.org/23596007/diff/3001/pkg/yaml/lib/yaml.dart#new...
pkg/yaml/lib/yaml.dart:32: /// `stringify` from `dart:json` instead:
Update this line.

[Bob Nystrom, 2013-08-27 18:15:53]

Changes to docgen, unittest, pub, and apidoc LGTM.

[Jennifer Messerly, 2013-08-27 18:29:28]

polymer + source_maps LGTM. Thanks!

[floitsch, 2013-08-28 08:26:44]

https://codereview.chromium.org/23596007/diff/3001/pkg/yaml/lib/yaml.dart
File pkg/yaml/lib/yaml.dart (right):

https://codereview.chromium.org/23596007/diff/3001/pkg/yaml/lib/yaml.dart#new...
pkg/yaml/lib/yaml.dart:32: /// `stringify` from `dart:json` instead:
On 2013/08/27 17:05:02, nweiz wrote:
> Update this line.

Done.

[Lasse Reichstein Nielsen, 2013-08-28 09:51:49]

lgtm

https://codereview.chromium.org/23596007/diff/3001/samples/third_party/dromae...
File samples/third_party/dromaeo/tests/dom-modify-html.dart (right):

https://codereview.chromium.org/23596007/diff/3001/samples/third_party/dromae...
samples/third_party/dromaeo/tests/dom-modify-html.dart:16: str = "$str${new
String.fromCharCodes([((25 * random.nextDouble()) + 97).toInt()])}";
Long line.
Could you at least rewrite to:
  str += new string.fromCharCode((25 * random.nextDouble() + 97).toInt());

It's even closer to the JS version :)

[floitsch, 2013-08-28 14:01:11]

@john: please verify that my change to
samples/third_party/dromaeo/tests/dom-modify-html.dart is ok.

https://codereview.chromium.org/23596007/diff/3001/samples/third_party/dromae...
File samples/third_party/dromaeo/tests/dom-modify-html.dart (right):

https://codereview.chromium.org/23596007/diff/3001/samples/third_party/dromae...
samples/third_party/dromaeo/tests/dom-modify-html.dart:16: str = "$str${new
String.fromCharCodes([((25 * random.nextDouble()) + 97).toInt()])}";
On 2013/08/28 09:51:49, Lasse Reichstein Nielsen wrote:
> Long line.
> Could you at least rewrite to:
>   str += new string.fromCharCode((25 * random.nextDouble() + 97).toInt());
> 
> It's even closer to the JS version :)

Done.

[floitsch, 2013-08-28 14:06:47]

Committed patchset #5 manually as r26789 (presubmit successful).

[Jennifer Messerly, 2013-08-28 20:55:34]

Dromaeo changes look okay to me but not 100% sure, adding Emily for another
look.

[Emily Fortuna, 2013-08-28 21:09:54]

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
File samples/third_party/dromaeo/tests/dom-modify-html.dart (right):

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
samples/third_party/dromaeo/tests/dom-modify-html.dart:17: str += new
String.fromCharCode(((25 * random.nextDouble()) + 97).toInt());
Are these two forms identical, perf-wise? I'm not certain what's going on "under
the hood"

[floitsch, 2013-08-28 21:12:14]

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
File samples/third_party/dromaeo/tests/dom-modify-html.dart (right):

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
samples/third_party/dromaeo/tests/dom-modify-html.dart:17: str += new
String.fromCharCode(((25 * random.nextDouble()) + 97).toInt());
On 2013/08/28 21:09:54, Emily Fortuna wrote:
> Are these two forms identical, perf-wise? I'm not certain what's going on
"under
> the hood"

The new one could be faster (although I'm not sure we already implemented it).
If speed is an issue it shouldn't use string-concatenation, but a string-buffer.

[Emily Fortuna, 2013-08-28 21:19:00]

lgtm

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
File samples/third_party/dromaeo/tests/dom-modify-html.dart (right):

https://codereview.chromium.org/23596007/diff/19001/samples/third_party/droma...
samples/third_party/dromaeo/tests/dom-modify-html.dart:17: str += new
String.fromCharCode(((25 * random.nextDouble()) + 97).toInt());
On 2013/08/28 21:12:15, floitsch wrote:
> On 2013/08/28 21:09:54, Emily Fortuna wrote:
> > Are these two forms identical, perf-wise? I'm not certain what's going on
> "under
> > the hood"
> 
> The new one could be faster (although I'm not sure we already implemented it).
> If speed is an issue it shouldn't use string-concatenation, but a
string-buffer.

Agreed StringBuffer is the fastest way for sure-- I think they were trying to
keep this test similar to the original JS version so that they could compare
apples-to...almost apples. :-)