Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 235953019: Exit stdio-based analysis server when stdin closed. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Exit stdio-based analysis server when stdin closed. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35116

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M pkg/analysis_server/lib/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/http_server.dart View 3 chunks +14 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel.dart View 1 chunk +16 lines, -1 line 2 comments Download
M pkg/analysis_server/lib/stdio_server.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/channel_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-16 17:09:30 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/235953019/diff/1/pkg/analysis_server/lib/src/channel.dart File pkg/analysis_server/lib/src/channel.dart (right): https://codereview.chromium.org/235953019/diff/1/pkg/analysis_server/lib/src/channel.dart#newcode201 pkg/analysis_server/lib/src/channel.dart:201: _closed.complete(); Out of curiosity, why not just add ...
6 years, 8 months ago (2014-04-16 17:23:42 UTC) #2
Paul Berry
https://codereview.chromium.org/235953019/diff/1/pkg/analysis_server/lib/src/channel.dart File pkg/analysis_server/lib/src/channel.dart (right): https://codereview.chromium.org/235953019/diff/1/pkg/analysis_server/lib/src/channel.dart#newcode201 pkg/analysis_server/lib/src/channel.dart:201: _closed.complete(); On 2014/04/16 17:23:43, Brian Wilkerson wrote: > Out ...
6 years, 8 months ago (2014-04-16 17:28:40 UTC) #3
Paul Berry
6 years, 8 months ago (2014-04-16 17:34:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698