Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 235933014: Allowing Angular sample to run on dev branch with Angular 0.9.10 (Closed)

Created:
6 years, 8 months ago by blois
Modified:
6 years, 8 months ago
Reviewers:
ricow1, nweiz, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allowing Angular sample to run on dev branch with Angular 0.9.10 This overrides Angular's analyzer version which is used for command-line tools only to match the version used by DI 0.36.0, so that the published version of Angular will work on the Dart dev branch. The dependency override only works now because the analyzer dependency is only for the command-line utilities which are being phased out in favor of transformers (appearing in next Angular version). BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35056

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/pkgbuild.status View 1 chunk +0 lines, -1 line 0 comments Download
M samples/third_party/angular_todo/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
This is a bit of a hack, but allows us to not be blocked on ...
6 years, 8 months ago (2014-04-15 01:16:37 UTC) #1
nweiz
lgtm
6 years, 8 months ago (2014-04-15 01:18:02 UTC) #2
blois
6 years, 8 months ago (2014-04-15 01:20:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698