Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 235913003: third_party/pkg/markdown: update to 0.7.0 which fixes static warnings (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

third_party/pkg/markdown: update to 0.7.0 which fixes static warnings BUG=https://code.google.com/p/dart/issues/detail?id=17896 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=35025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/pkg/markdown/lib/src/inline_parser.dart View 9 chunks +13 lines, -16 lines 0 comments Download
M third_party/pkg/markdown/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo
6 years, 8 months ago (2014-04-12 01:08:39 UTC) #1
Alan Knight
Is it a good idea to change things in third_party directly and get them out ...
6 years, 8 months ago (2014-04-14 16:28:43 UTC) #2
kevmoo
On 2014/04/14 16:28:43, Alan Knight wrote: > Is it a good idea to change things ...
6 years, 8 months ago (2014-04-14 16:48:17 UTC) #3
Alan Knight
This seems like a very error-prone way to incorporate updates into third_party, but ok. LGTM.
6 years, 8 months ago (2014-04-14 17:12:28 UTC) #4
kevmoo
6 years, 8 months ago (2014-04-14 17:16:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r35025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698