Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 23591069: Fix runtime clamp logic to match optimized code (Closed)

Created:
7 years, 2 months ago by Cutch
Modified:
7 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix runtime clamp logic to match optimized code BUG=13106 R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=27911

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -12 lines) Patch
M runtime/lib/simd128.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download
A tests/lib/typed_data/float32x4_clamp_test.dart View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
7 years, 2 months ago (2013-09-24 14:46:32 UTC) #1
zra
lgtm Why does it have to match optimized code exactly?
7 years, 2 months ago (2013-09-24 16:17:56 UTC) #2
Cutch
7 years, 2 months ago (2013-09-25 20:43:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698