Issue 23591046: Making Document, Element and Window documentable via @DocsEditable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591046: Making Document, Element and Window documentable via @DocsEditable (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Making Document, Element and Window documentable via @DocsEditable TBR BUG=13291 Committed: https://code.google.com/p/dart/source/detail?r=27503

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -12 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/docs/docs.json	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Document.darttemplate	View	1 chunk	+1 line, -9 lines	1 comment	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r27503 (presubmit successful).

7 years, 3 months ago (2013-09-13 21:23:13 UTC) #2

Emily Fortuna

https://codereview.chromium.org/23591046/diff/1/tools/dom/templates/html/impl/impl_Document.darttemplate File tools/dom/templates/html/impl/impl_Document.darttemplate (right): https://codereview.chromium.org/23591046/diff/1/tools/dom/templates/html/impl/impl_Document.darttemplate#newcode7 tools/dom/templates/html/impl/impl_Document.darttemplate:7: @DocsEditable is this really an improvement? I think it's ...

7 years, 3 months ago (2013-09-14 03:47:43 UTC) #3

Emily Fortuna

7 years, 3 months ago (2013-09-14 03:48:52 UTC) #4

Message was sent while issue was closed.

just saw the bug about this.
lgtm, but we really should have a better system for this! I really don't like
this set-up

Expand Messages | Collapse Messages