Clean up handling of guarded fields in the flow graph builder.

Clean up handling of guarded fields in the flow graph builder.

FlowGraphBuilder has a zone-allocated list of fields and passes it
on to the FlowGraph.

R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27699

[Florian Schneider, 2013-09-20 11:26:20]

I had to make the helper AddToGuardedField static because it is used in
FlowGraphBuilder and there is no FlowGraph allocated yet at that time.

[Kevin Millikin (Google), 2013-09-20 12:04:27]

LGTM with a pointlessly nitpicky suggestion.

https://codereview.chromium.org/23589008/diff/1/runtime/vm/flow_graph.h
File runtime/vm/flow_graph.h (right):

https://codereview.chromium.org/23589008/diff/1/runtime/vm/flow_graph.h#newco...
runtime/vm/flow_graph.h:200: static void AddToGuardedFields(const Field* field,
I like reversing the arguments here, because it matches (target, source) that we
use in a lot of other places.

[Florian Schneider, 2013-09-20 12:13:50]

https://codereview.chromium.org/23589008/diff/1/runtime/vm/flow_graph.h
File runtime/vm/flow_graph.h (right):

https://codereview.chromium.org/23589008/diff/1/runtime/vm/flow_graph.h#newco...
runtime/vm/flow_graph.h:200: static void AddToGuardedFields(const Field* field,
On 2013/09/20 12:04:28, kmillikin wrote:
> I like reversing the arguments here, because it matches (target, source) that
we
> use in a lot of other places.

Done.

[Florian Schneider, 2013-09-20 12:14:15]

Committed patchset #2 manually as r27699 (presubmit successful).