Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 23589005: Formatter comment-handling improvements. (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter comment-handling improvements. A bit messy but ready to checkpoint. Should handle the major cases. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=27074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -44 lines) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 8 chunks +91 lines, -43 lines 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 3 chunks +130 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 3 months ago (2013-09-03 18:02:49 UTC) #1
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-03 18:29:29 UTC) #2
pquitslund
7 years, 3 months ago (2013-09-03 19:21:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698