pkg/docgen: support better const rendering of String, List, and empty Map

pkg/docgen: support better const rendering of String, List, and empty Map

BUG= https://code.google.com/p/dart/issues/detail?id=18107
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35140

[kevmoo, 2014-04-16 21:07:11]

FYI

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status
File pkg/pkg.status (left):

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#oldcode20
pkg/pkg.status:20: [ $compiler == dart2js && $mode == debug ]
I'm skipping all docgen tests unless we're on the VM, not debug, and not ARM or
MIPS

Just too darn slow

The rest of the changes are just sorting

[Emily Fortuna, 2014-04-16 22:13:40]

minor adjustments, then lgtm

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
File pkg/docgen/test/constant_argument_test.dart (right):

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
pkg/docgen/test/constant_argument_test.dart:10: import 'package:path/path.dart'
as p;
I hate single letter names for these, but since it's a test I'll let it slide...

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
pkg/docgen/test/constant_argument_test.dart:40:
testLibBar['functions']['methods']['positionalDefaultValues'] as Map<String,
80 char

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode29
pkg/pkg.status:29: polymer/test/build/all_phases_test: Skip # Slow
You have two lines for the same test. which one is it? Pass,Timeout or Skip?
(probably Skip)

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode30
pkg/pkg.status:30: polymer/test/build/script_compactor_test: Pass, Timeout
generally we say if it is a pass or timeout, just skip it. there's not much to
be gained from running it to ensure it times out

[kevmoo, 2014-04-17 00:01:19]

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
File pkg/docgen/test/constant_argument_test.dart (right):

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
pkg/docgen/test/constant_argument_test.dart:10: import 'package:path/path.dart'
as p;
On 2014/04/16 22:13:40, Emily Fortuna wrote:
> I hate single letter names for these, but since it's a test I'll let it
slide...

'p' is a pretty common convention, at least for Bob/Nathan code.

https://codereview.chromium.org/235883016/diff/1/pkg/docgen/test/constant_arg...
pkg/docgen/test/constant_argument_test.dart:40:
testLibBar['functions']['methods']['positionalDefaultValues'] as Map<String,
On 2014/04/16 22:13:40, Emily Fortuna wrote:
> 80 char

Done.

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode29
pkg/pkg.status:29: polymer/test/build/all_phases_test: Skip # Slow
On 2014/04/16 22:13:40, Emily Fortuna wrote:
> You have two lines for the same test. which one is it? Pass,Timeout or Skip?
> (probably Skip)

I didn't tweak these...this is just the result of sorting. Going with skip seems
goodness

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode30
pkg/pkg.status:30: polymer/test/build/script_compactor_test: Pass, Timeout
On 2014/04/16 22:13:40, Emily Fortuna wrote:
> generally we say if it is a pass or timeout, just skip it. there's not much to
> be gained from running it to ensure it times out

This isn't my line...just a diff from sorting. Leaving it as it is.

At least it'll be easier to find now...hopefully

[kevmoo, 2014-04-17 00:02:19]

Committed patchset #2 manually as r35140 (presubmit successful).

[Emily Fortuna, 2014-04-17 16:11:44]

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode29
pkg/pkg.status:29: polymer/test/build/all_phases_test: Skip # Slow
On 2014/04/17 00:01:19, kevmoo wrote:
> On 2014/04/16 22:13:40, Emily Fortuna wrote:
> > You have two lines for the same test. which one is it? Pass,Timeout or Skip?
> > (probably Skip)
> 
> I didn't tweak these...this is just the result of sorting. Going with skip
seems
> goodness

Yes, and thank you for sorting. It's indicative that someone added the status in
two different places without realizing it because of no sorting. Thanks for
coalescing.

https://codereview.chromium.org/235883016/diff/1/pkg/pkg.status#newcode30
pkg/pkg.status:30: polymer/test/build/script_compactor_test: Pass, Timeout
On 2014/04/17 00:01:19, kevmoo wrote:
> On 2014/04/16 22:13:40, Emily Fortuna wrote:
> > generally we say if it is a pass or timeout, just skip it. there's not much
to
> > be gained from running it to ensure it times out
> 
> This isn't my line...just a diff from sorting. Leaving it as it is.
> 
> At least it'll be easier to find now...hopefully

I know you didn't change them, but I was making a suggestion for improvement...
next time!