Issue 23583054: Revert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23583054: Revert (Closed)

Created:
7 years, 3 months ago by siva

Modified:
7 years, 3 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -98 lines)			Patch
M	runtime/vm/compiler.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	4 chunks	+0 lines, -27 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	8 chunks	+9 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+15 lines, -1 line	0 comments	Download
D	tests/language/vm/optimized_guarded_field_test.dart	View	1 chunk	+0 lines, -35 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

I don't particularly like reverting changes. I would prefer if they could be fixed in ...

7 years, 3 months ago (2013-09-19 20:29:50 UTC) #2

siva

7 years, 3 months ago (2013-09-19 20:32:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27675 (presubmit successful).