Don't expect String on read-errors.

Don't expect String on read-errors.

BUG=
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27615

[ahe, 2013-09-10 10:50:27]

Not sure about this.

https://codereview.chromium.org/23583041/diff/1/tests/compiler/dart2js/memory...
File tests/compiler/dart2js/memory_source_file_helper.dart (right):

https://codereview.chromium.org/23583041/diff/1/tests/compiler/dart2js/memory...
tests/compiler/dart2js/memory_source_file_helper.dart:37: return new
Future.error(new Exception('No such file $resourceUri'));
Why do you need to wrap this in an exception?

[Johnni Winther, 2013-09-10 11:41:52]

https://codereview.chromium.org/23583041/diff/1/tests/compiler/dart2js/memory...
File tests/compiler/dart2js/memory_source_file_helper.dart (right):

https://codereview.chromium.org/23583041/diff/1/tests/compiler/dart2js/memory...
tests/compiler/dart2js/memory_source_file_helper.dart:37: return new
Future.error(new Exception('No such file $resourceUri'));
On 2013/09/10 10:50:28, ahe wrote:
> Why do you need to wrap this in an exception?

I don't need to, but I found the type error in reportReadError when an imported
file could not be found by the file system. Wrapping the string in an exception
mimics the error from the file system and makes this behaviour testable in
missing_file_test.

[Johnni Winther, 2013-09-17 07:49:38]

ping

[ahe, 2013-09-17 07:52:25]

LGTM

[Johnni Winther, 2013-09-18 12:52:18]

Committed patchset #1 manually as r27615 (presubmit successful).