Fix dart2js decimal number tokenization.

Fix dart2js decimal number tokenization. Remove support for 'd'-suffixed double format.

BUG=dartbug.com/13070

[aam-me, 2013-09-06 03:52:41]

Hi Peter,

  please take a look at the bugfix.
  It seems that support for 'd'-suffixed doubles was there since very first
revision of dart2js.

Thanks.

[ahe, 2013-09-06 14:20:25]

Nice!

https://codereview.chromium.org/23583038/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/scanner/scanner.dart (right):

https://codereview.chromium.org/23583038/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/scanner/scanner.dart:465: int nextnext
= peek();
Can you avoid calling peek until you see a '.'?

https://codereview.chromium.org/23583038/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/scanner/scanner.dart:468: } else if
(identical(next, $PERIOD)
Would this work:

} else if (identical(next, $PERIOD)) {
  int nextnext = peek();
  if ($0 <= nextnext && nextnext <= $9) {
    return tokenizeFractionPart(advance(), start);
  }
  appendByteStringToken(INT_INFO, asciiString(start, 0));
  return next;
} else if ...

This duplicates code, but reduces look-ahead.

[aam-me, 2013-09-06 17:09:47]

On 2013/09/06 14:20:25, ahe wrote:
> Nice!

Thanks!

> Can you avoid calling peek until you see a '.'?

Certainly!

> Would this work:
> 
> } else if (identical(next, $PERIOD)) {
>   int nextnext = peek();
>   if ($0 <= nextnext && nextnext <= $9) {
>     return tokenizeFractionPart(advance(), start);
>   }
>   appendByteStringToken(INT_INFO, asciiString(start, 0));
>   return next;
> } else if ...
> 
> This duplicates code, but reduces look-ahead.

I reshuffled the code slightly to avoid code duplication.
The price - check for '.' now comes after check for 'E'/'e'.

What do you think?

[aam-me, 2013-09-10 01:28:03]

Hi Peter,

  I updated language_analyzer.status as Brian fixed decimal number tokenization
issue.

PTAL

[ahe, 2013-09-10 08:35:46]

LGTM!