Issue 23583035: Emit a compile-time error when returning a value from a constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23583035: Emit a compile-time error when returning a value from a constructor. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit a compile-time error when returning a value from a constructor. BUG=dartbug.com/12937, dartbug.com/12938 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27129

Patch Set 1 #

Patch Set 2 : Add a reference to spec. #

Patch Set 3 : Remove type-checker warning. #

Patch Set 4 : Include howToFix and example in error message. #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2 3	1 chunk	+12 lines, -0 lines	1 comment	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

Committed patchset #4 manually as r27129 (presubmit successful).

7 years, 3 months ago (2013-09-04 13:45:55 UTC) #3

ahe

7 years, 3 months ago (2013-09-05 08:35:20 UTC) #4

Message was sent while issue was closed.

Nice example!

https://codereview.chromium.org/23583035/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/23583035/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:504: "Error: Cannot
return a value from a constructor.",
Prefer "can't" over "cannot" (the guidelines were updated based on feedback from
usability experts and tech writers).

Expand Messages | Collapse Messages