Issue 23583002: Make dart:io SecureSocket builtin root certificate test more robust, merge test files.

Issue 23583002: Make dart:io SecureSocket builtin root certificate test more robust, merge test files. (Closed)

Created:
7 years, 3 months ago by Bill Hesse

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make dart:io SecureSocket builtin root certificate test more robust, merge test files. BUG=dartbug.com/12770 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26709

Patch Set 1 #

Total comments: 3

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -135 lines)			Patch
D	tests/standalone/io/secure_builtin_roots_database_test.dart	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	tests/standalone/io/secure_builtin_roots_test.dart	View	1 chunk	+74 lines, -16 lines	3 comments	Download
D	tests/standalone/io/secure_no_builtin_roots_database_test.dart	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	tests/standalone/io/secure_no_builtin_roots_test.dart	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/23583002/diff/1/tests/standalone/io/secure_builtin_roots_test.dart File tests/standalone/io/secure_builtin_roots_test.dart (right): https://codereview.chromium.org/23583002/diff/1/tests/standalone/io/secure_builtin_roots_test.dart#newcode47 tests/standalone/io/secure_builtin_roots_test.dart:47: print('SUCCESS'); Debug print. https://codereview.chromium.org/23583002/diff/1/tests/standalone/io/secure_builtin_roots_test.dart#newcode54 tests/standalone/io/secure_builtin_roots_test.dart:54: print('SUCCESS'); Ditto.

7 years, 3 months ago (2013-08-27 12:16:46 UTC) #2

Bill Hesse

https://codereview.chromium.org/23583002/diff/1/tests/standalone/io/secure_builtin_roots_test.dart File tests/standalone/io/secure_builtin_roots_test.dart (right): https://codereview.chromium.org/23583002/diff/1/tests/standalone/io/secure_builtin_roots_test.dart#newcode47 tests/standalone/io/secure_builtin_roots_test.dart:47: print('SUCCESS'); On 2013/08/27 12:16:46, Søren Gjesse wrote: > Debug ...

7 years, 3 months ago (2013-08-27 12:21:33 UTC) #3

Bill Hesse

7 years, 3 months ago (2013-08-27 12:22:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26709 (presubmit successful).

Expand Messages | Collapse Messages