Issue 23582004: Fix bad language test (issue 12757, 12758).

Issue 23582004: Fix bad language test (issue 12757, 12758). (Closed)

Created:
7 years, 3 months ago by regis

Modified:
7 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bad language test (issue 12757, 12758). Update status files accordingly (new VM issue was filed). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26742

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	tests/language/call_nonexistent_constructor_test.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/23582004/diff/1/tests/language/call_nonexistent_constructor_test.dart File tests/language/call_nonexistent_constructor_test.dart (right): https://codereview.chromium.org/23582004/diff/1/tests/language/call_nonexistent_constructor_test.dart#newcode22 tests/language/call_nonexistent_constructor_test.dart:22: new A.bar(foo()); // Arguments are evaluated with NoSuchMethodError. ...

7 years, 3 months ago (2013-08-27 20:07:48 UTC) #2

regis

Thanks! Cc'ing Zach, since he got the privilege to fix related issue 12820. -- Regis ...

7 years, 3 months ago (2013-08-27 20:37:22 UTC) #3

regis

7 years, 3 months ago (2013-08-27 20:37:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26742 (presubmit successful).

Expand Messages | Collapse Messages