Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 23582003: Use filtered stacks in pub, barback, and watcher tests. (Closed)

Created:
7 years, 3 months ago by nweiz
Modified:
7 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use filtered stacks in pub, barback, and watcher tests. This also exposes more unittest stuff to users of scheduled_test. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/barback/test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/watcher/test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 3 months ago (2013-08-27 18:34:23 UTC) #1
Bob Nystrom
LGTM!
7 years, 3 months ago (2013-08-27 22:15:29 UTC) #2
nweiz
7 years, 3 months ago (2013-08-27 23:13:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698