Issue 23581017: Re-apply r27739: Fix invocation_mirror_test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23581017: Re-apply r27739: Fix invocation_mirror_test.dart. (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -13 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	5 chunks	+25 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/type_graph_inferrer.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

Patchset 1 contains the original CL. Patchset 2 contains the fix.

7 years, 3 months ago (2013-09-23 09:16:29 UTC) #1

karlklose

LGTM, but could you change the CL title to include the original title (instead of ...

7 years, 3 months ago (2013-09-23 09:29:17 UTC) #2

ngeoffray

On 2013/09/23 09:29:17, karlklose wrote: > LGTM, but could you change the CL title to ...

7 years, 3 months ago (2013-09-23 11:01:32 UTC) #3

ngeoffray

7 years, 3 months ago (2013-09-23 11:07:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27751 (presubmit successful).