Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 23578046: Replace the memcpy macro with a lint check. (Closed)

Created:
7 years, 3 months ago by pcc
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Replace the memcpy macro with a lint check. This fixes the build under libc++. It also allows us to check the Windows and Android code. While at it, replace all uncaught instances of memcpy with memmove. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M runtime/PRESUBMIT.py View 3 chunks +18 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/globals.h View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pcc
7 years, 3 months ago (2013-09-18 22:23:02 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-19 06:47:21 UTC) #2
Søren Gjesse
7 years, 3 months ago (2013-09-20 12:25:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698