Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 23578003: - Tests should not rely on --compile_all. (Closed)

Created:
7 years, 3 months ago by Ivan Posva
Modified:
7 years, 3 months ago
Reviewers:
siva, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Tests should not rely on --compile_all. Committed: https://code.google.com/p/dart/source/detail?r=26723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tests/language/external_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/language/get_set_syntax_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/syntax_test.dart View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
7 years, 3 months ago (2013-08-27 17:07:57 UTC) #1
Ivan Posva
Committed patchset #1 manually as r26723 (presubmit successful).
7 years, 3 months ago (2013-08-27 17:09:29 UTC) #2
siva
lgtm
7 years, 3 months ago (2013-08-27 17:09:32 UTC) #3
kustermann
7 years, 3 months ago (2013-08-28 00:35:46 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698