Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 23576013: Fixing Element.shadowRoot to work with webkitShadowRoot (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing Element.shadowRoot to work with webkitShadowRoot Chrome 31 changed it to shadowRoot, need to support the prefixed version as well. BUG=13061 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=27203

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/html/shadowroot_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-05 17:16:40 UTC) #1
Jacob
lgtm
7 years, 3 months ago (2013-09-05 17:31:09 UTC) #2
blois
7 years, 3 months ago (2013-09-05 17:47:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698