Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 23566008: Rename Match.str to input. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Rename Match.str to input. Cleanup of Match and RegExp documentation. BUG= http://dartbug.com/8333 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26776

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -34 lines) Patch
M runtime/lib/regexp_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_collection_dev/iterable.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/core/regexp.dart View 1 5 chunks +70 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-28 09:30:15 UTC) #1
floitsch
LGTM with comments. https://codereview.chromium.org/23566008/diff/1/sdk/lib/core/regexp.dart File sdk/lib/core/regexp.dart (right): https://codereview.chromium.org/23566008/diff/1/sdk/lib/core/regexp.dart#newcode70 sdk/lib/core/regexp.dart:70: * `0` to [groupCount] (inclusive), in ...
7 years, 3 months ago (2013-08-28 09:34:50 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/23566008/diff/1/sdk/lib/core/regexp.dart File sdk/lib/core/regexp.dart (right): https://codereview.chromium.org/23566008/diff/1/sdk/lib/core/regexp.dart#newcode70 sdk/lib/core/regexp.dart:70: * `0` to [groupCount] (inclusive), in that order. Ack, ...
7 years, 3 months ago (2013-08-28 10:43:23 UTC) #3
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-28 10:47:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698