Issue 23565007: Make sure we're not trying to optimize an int check if the input can be a number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23565007: Make sure we're not trying to optimize an int check if the input can be a number. (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make sure we're not trying to optimize an int check if the input can be a number. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27034

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -14 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/concrete_type_inference_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
A	tests/compiler/dart2js_extra/inferrer_is_int_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

7 years, 3 months ago (2013-09-03 10:23:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r27034 (presubmit successful).