Issue 23561005: Disable new browser controller on win-chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23561005: Disable new browser controller on win-chrome (Closed)

Created:
7 years, 3 months ago by kustermann

Modified:
7 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disable new browser controller on win-chrome test.dart is not able to determine the version of chrome when running 'chrome.exe --version'. This causes an open browser window to hang and makes the bot timeout. TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27245

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	dart/tools/bots/compiler.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	dart/tools/testing/dart/browser_controller.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #1 manually as r27245 (presubmit successful).

7 years, 3 months ago (2013-09-06 12:22:39 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages