Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 235573006: Validate native tags (Closed)

Created:
6 years, 8 months ago by sra1
Modified:
6 years, 8 months ago
Reviewers:
floitsch, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Validate native tags Fix dart:html problem where tag is used by two classes. (Current IDL now has correct inheritance.) R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34990

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 3 chunks +3 lines, -21 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 2 chunks +35 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 8 months ago (2014-04-11 19:35:42 UTC) #1
blois
lgtm
6 years, 8 months ago (2014-04-11 19:37:46 UTC) #2
sra1
6 years, 8 months ago (2014-04-11 19:42:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698