Made old dart:json library use convert to parse JSON.

Made old dart:json library use convert to parse JSON.

Moved JSON implementation into convert_patch files.
Move error classes into convert library, and reexport from dart:json.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26767

[Lasse Reichstein Nielsen, 2013-08-27 13:00:53]

FSchneider, please check VM changes.

[floitsch, 2013-08-27 13:25:39]

LGTM.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
File sdk/lib/_internal/lib/convert_patch.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
sdk/lib/_internal/lib/convert_patch.dart:93: return revive(null, walk(json));
Let's do this change in a separate CL.
Otherwise it drowns among all the other changes.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:13: * method on the object. If that call fails, the
error will be stored in the
is stored

Should we keep the `toJson` call. (If no. A separate CL).

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:15: * serializable, the [cause] will be null.
is `null`.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode74
sdk/lib/json/json.dart:74: reviver = (key, value) => original(key == null ? "" :
key, value);
Again: let's make this in a separate CL.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
File tests/lib/convert/codec2_test.dart (right):

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:25: if (k == null) return v;
next CL.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:30: if (k == null) return v;
ditto.

[floitsch, 2013-08-27 13:27:50]

Also make sure not to break code because of the conflict dart:convert /
dart:json.

It seems unlikely since dart:json is almost always imported with a prefix
("json" or "JSON").

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode25
sdk/lib/json/json.dart:25: class JsonUnsupportedObjectError extends Error {
Didn't you want to reexport these?
Otherwise a user of dart:json won't be able to catch with
JsonUnsupportedObjectError.

[Lasse Reichstein Nielsen, 2013-08-28 07:56:32]

Committed patchset #2 manually as r26767 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-08-28 08:02:59]

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
File sdk/lib/_internal/lib/convert_patch.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
sdk/lib/_internal/lib/convert_patch.dart:93: return revive(null, walk(json));
On 2013/08/27 13:25:40, floitsch wrote:
> Let's do this change in a separate CL.
> Otherwise it drowns among all the other changes.

Done.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:13: * method on the object. If that call fails, the
error will be stored in the
I'd say "no".
We should have a function, the opposite of "reviver", which converts
non-JSON-able objects to JSON-able objects. It could default to just calling
toJson() on the object, or we could default to throwing, and have the old
library call it with a function that calls toJson.

We haven't touched "stringify" yet, right?

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:15: * serializable, the [cause] will be null.
On 2013/08/27 13:25:40, floitsch wrote:
> is `null`.

Done.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode25
sdk/lib/json/json.dart:25: class JsonUnsupportedObjectError extends Error {
Absolutely. Wonder where the export statement got lost.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode74
sdk/lib/json/json.dart:74: reviver = (key, value) => original(key == null ? "" :
key, value);
On 2013/08/27 13:25:40, floitsch wrote:
> Again: let's make this in a separate CL.

Done.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
File tests/lib/convert/codec2_test.dart (right):

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:25: if (k == null) return v;
On 2013/08/27 13:25:40, floitsch wrote:
> next CL.

Done.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:30: if (k == null) return v;
On 2013/08/27 13:25:40, floitsch wrote:
> ditto.

Done.

[Lasse Reichstein Nielsen, 2013-08-28 08:02:59]

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
File sdk/lib/_internal/lib/convert_patch.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/_internal/lib/convert...
sdk/lib/_internal/lib/convert_patch.dart:93: return revive(null, walk(json));
On 2013/08/27 13:25:40, floitsch wrote:
> Let's do this change in a separate CL.
> Otherwise it drowns among all the other changes.

Done.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:13: * method on the object. If that call fails, the
error will be stored in the
I'd say "no".
We should have a function, the opposite of "reviver", which converts
non-JSON-able objects to JSON-able objects. It could default to just calling
toJson() on the object, or we could default to throwing, and have the old
library call it with a function that calls toJson.

We haven't touched "stringify" yet, right?

https://codereview.chromium.org/23554004/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:15: * serializable, the [cause] will be null.
On 2013/08/27 13:25:40, floitsch wrote:
> is `null`.

Done.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode25
sdk/lib/json/json.dart:25: class JsonUnsupportedObjectError extends Error {
Absolutely. Wonder where the export statement got lost.

https://codereview.chromium.org/23554004/diff/1/sdk/lib/json/json.dart#newcode74
sdk/lib/json/json.dart:74: reviver = (key, value) => original(key == null ? "" :
key, value);
On 2013/08/27 13:25:40, floitsch wrote:
> Again: let's make this in a separate CL.

Done.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
File tests/lib/convert/codec2_test.dart (right):

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:25: if (k == null) return v;
On 2013/08/27 13:25:40, floitsch wrote:
> next CL.

Done.

https://codereview.chromium.org/23554004/diff/1/tests/lib/convert/codec2_test...
tests/lib/convert/codec2_test.dart:30: if (k == null) return v;
On 2013/08/27 13:25:40, floitsch wrote:
> ditto.

Done.