Issue 23551007: Remove reference to unimported Future.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23551007: Remove reference to unimported Future. (Closed)

Created:
7 years, 3 months ago by Johnni Winther

Modified:
7 years, 3 months ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove reference to unimported Future. BUG= Committed: https://code.google.com/p/dart/source/detail?r=27030

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/async_helper/lib/async_helper.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Committed patchset #1 manually as r27030 (presubmit successful).

7 years, 3 months ago (2013-09-03 08:28:31 UTC) #2

ahe

LGTM, with a really important comment about a very severe issue. https://codereview.chromium.org/23551007/diff/1/pkg/async_helper/lib/async_helper.dart File pkg/async_helper/lib/async_helper.dart (right): ...

7 years, 3 months ago (2013-09-03 08:28:51 UTC) #3

kustermann

7 years, 3 months ago (2013-09-03 13:53:03 UTC) #4

Message was sent while issue was closed.

Would be nice if you could CC me for async_helper changes.

https://codereview.chromium.org/23551007/diff/1/pkg/async_helper/lib/async_he...
File pkg/async_helper/lib/async_helper.dart (right):

https://codereview.chromium.org/23551007/diff/1/pkg/async_helper/lib/async_he...
pkg/async_helper/lib/async_helper.dart:65: void asyncTest(f()) {
You could add some documentation to the top of the file.

Expand Messages | Collapse Messages