Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 235503007: Exposing Node.baseURL (Closed)

Created:
6 years, 8 months ago by blois
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Exposing Node.baseURL Polymer uses it quite a bit, seems like Dart should expose it. It's primarily useful in Polymer because with HTMLImports it's easy to load content with different base URIs. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 8 months ago (2014-04-12 21:01:19 UTC) #1
Jennifer Messerly
lgtm
6 years, 8 months ago (2014-04-14 19:17:30 UTC) #2
blois
6 years, 8 months ago (2014-04-14 21:37:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698