Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 23550002: Mark some tests as failing instead of skipping. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Mark some tests as failing instead of skipping. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26698

Patch Set 1 #

Patch Set 2 : One wasn't failing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-27 08:37:41 UTC) #1
floitsch
LGTM.
7 years, 3 months ago (2013-08-27 08:48:56 UTC) #2
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-27 09:26:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698