Issue 23549013: Preserves callee-saved FPU registers on ARM

Issue 23549013: Preserves callee-saved FPU registers on ARM (Closed)

Created:
7 years, 3 months ago by zra

Modified:
7 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Preserves callee-saved FPU registers on ARM Preserves callee-saved FPU registers on ARM when going from C++ to Dart code. Adds assertions to the simulator to make sure this is being done correctly. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=27072

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -15 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_arm.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1	4 chunks	+37 lines, -0 lines	0 comments	Download
M	runtime/vm/stack_frame_arm.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	4 chunks	+13 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/23549013/diff/1/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/23549013/diff/1/runtime/vm/assembler_arm.cc#newcode2516 runtime/vm/assembler_arm.cc:2516: kDartVolatileFpuRegCount * (4 * kWordSize); (4 * kWordSize) ...

7 years, 3 months ago (2013-09-03 18:05:08 UTC) #2

zra

Thanks! https://codereview.chromium.org/23549013/diff/1/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/23549013/diff/1/runtime/vm/assembler_arm.cc#newcode2516 runtime/vm/assembler_arm.cc:2516: kDartVolatileFpuRegCount * (4 * kWordSize); On 2013/09/03 18:05:08, ...

7 years, 3 months ago (2013-09-03 18:22:45 UTC) #3

zra

7 years, 3 months ago (2013-09-03 18:23:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27072 (presubmit successful).

Expand Messages | Collapse Messages