Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 23548014: update shadowdom polyfill to latest (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update shadowdom polyfill to latest. Note: all of the changes to .debug.js and .min.js come from upstream I also simplified our patch, because we are now almost unforked upstream code (we just have a couple of fixes they haven't merged yet). In particular we can't use _ShadowDOMPolyfill$isGeneratedWrapper so we go back to 'GeneratedWrapper'. I'm trying to align our build logic more closely to: https://github.com/Polymer/platform/blob/master/gruntfile.js#L10, hence the use of their build.json files. This fixes: https://code.google.com/p/dart/issues/detail?id=13054 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27210

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : updated README, add build.sh #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -372 lines) Patch
M pkg/shadow_dom/lib/shadow_dom.debug.js View 1 2 74 chunks +857 lines, -293 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.min.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js View 1 2 1 chunk +14 lines, -11 lines 1 comment Download
A pkg/shadow_dom/tool/README.md View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A pkg/shadow_dom/tool/build.json View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/shadow_dom/tool/build.sh View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M pkg/shadow_dom/tool/gruntfile.js View 1 2 3 3 chunks +19 lines, -48 lines 0 comments Download
D pkg/shadow_dom/tool/readme.txt View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
with this change, Polymer+Firefox is working again :)
7 years, 3 months ago (2013-09-05 05:02:31 UTC) #1
Emily Fortuna
lgtm. I made a comment on shadow_dom.debug.js which I know you didn't write and comes ...
7 years, 3 months ago (2013-09-05 18:19:09 UTC) #2
Jennifer Messerly
Thanks! Can you please take another look? I have added "build.sh" and updated the README ...
7 years, 3 months ago (2013-09-05 19:47:02 UTC) #3
Emily Fortuna
looks good (lgtm), plus a nicely commented bash file! :-)
7 years, 3 months ago (2013-09-05 20:00:07 UTC) #4
Jennifer Messerly
Committed patchset #4 manually as r27210 (presubmit successful).
7 years, 3 months ago (2013-09-05 20:26:15 UTC) #5
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-09-08 18:44:22 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/23548014/diff/10001/pkg/shadow_dom/lib/src/pl...
File pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js (right):

https://codereview.chromium.org/23548014/diff/10001/pkg/shadow_dom/lib/src/pl...
pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js:43: // we know it
is some kind of Shadow DOM wrapper object.
I thought this is safe in debug mode, but that in minified mode the constructor
name appears obfuscated. Is there anything we can do to work around that?

Powered by Google App Engine
This is Rietveld 408576698