Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 23547005: Add async_helper package. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, ricow1, dgrove
Visibility:
Public.

Description

Add async_helper package. This package is private and should not be published to pub (nor should its documentation be published to api.dartlang.org). R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26774

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A + pkg/async_helper/lib/async_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/async_helper/pubspec.yaml View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/publish_all_pkgs.py View 1 chunk +3 lines, -1 line 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
I haven't tested the publish-package script, so please be extra-vigilant on that one.
7 years, 3 months ago (2013-08-27 13:03:39 UTC) #1
kustermann
LGTM But we should not maintain two versions. Why not converting the current tests to ...
7 years, 3 months ago (2013-08-27 14:29:30 UTC) #2
floitsch
I will convert the tests in a separate CL. I prefer to keep CLs smaller. ...
7 years, 3 months ago (2013-08-28 09:22:46 UTC) #3
floitsch
7 years, 3 months ago (2013-08-28 09:25:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698