Issue 23541003: Fix crash in compiler in the presence of "new library_prefix()".

Issue 23541003: Fix crash in compiler in the presence of "new library_prefix()". (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash in compiler in the presence of "new library_prefix()". R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=26692

Patch Set 2 : #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+11 lines, -5 lines	0 comments	Download
	A	tests/language/new_prefix_test.dart	View	1	1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Committed patchset #2 manually as r26692 (presubmit successful).

7 years, 3 months ago (2013-08-27 08:26:30 UTC) #3

ahe

https://codereview.chromium.org/23541003/diff/4001/tests/language/new_prefix_test.dart File tests/language/new_prefix_test.dart (right): https://codereview.chromium.org/23541003/diff/4001/tests/language/new_prefix_test.dart#newcode8 tests/language/new_prefix_test.dart:8: return new prefix(); /// 01: compile-time error This test ...

7 years, 3 months ago (2013-08-27 18:51:41 UTC) #4

ngeoffray

7 years, 3 months ago (2013-08-28 06:24:30 UTC) #5

Message was sent while issue was closed.

Thanks Peter.

https://codereview.chromium.org/23541003/diff/4001/tests/language/new_prefix_...
File tests/language/new_prefix_test.dart (right):

https://codereview.chromium.org/23541003/diff/4001/tests/language/new_prefix_...
tests/language/new_prefix_test.dart:8: return new prefix(); /// 01: compile-time
error
On 2013/08/27 18:51:42, ahe wrote:
> This test is not correct, see:
>
https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h....

Good catch. Luckily, the dart analyzer caught that, so I was able to fix it
here:

https://codereview.chromium.org/23498006/

Expand Messages | Collapse Messages