Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 23540004: Remove use of dart:json from third_party. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove use of dart:json from third_party. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M pkg/third_party/html5lib/test/parser_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/third_party/html5lib/test/tokenizer_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
I'm not sure if we should commit directly to third_party packages. But this is, what ...
7 years, 3 months ago (2013-08-27 15:50:06 UTC) #1
Jennifer Messerly
yeah, you can commit directly. In this case "third_party" just means it's under a different ...
7 years, 3 months ago (2013-08-27 17:44:23 UTC) #2
floitsch
7 years, 3 months ago (2013-08-28 15:39:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698