Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2353933002: Use configurable imports to avoid having two versions of everything. (Closed)

Created:
4 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Also remove some warnings. #

Patch Set 3 : Remove more warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/io_html.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lasse Reichstein Nielsen
4 years, 3 months ago (2016-09-20 12:50:16 UTC) #2
floitsch
LGTM.
4 years, 3 months ago (2016-09-20 14:17:13 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as f1c6229ffdb33a7f274fa819ebe5f0ca493ba3c5 (presubmit successful).
4 years, 3 months ago (2016-09-23 11:53:51 UTC) #5
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 799a627d802b42b244273c35b67f3504ea83f008 (presubmit successful).
4 years, 3 months ago (2016-09-23 12:05:18 UTC) #7
Lasse Reichstein Nielsen
4 years, 3 months ago (2016-09-23 12:08:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5ac9f73e5369922d5682608b4bfcbd92f1b667ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698