Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 23537051: Use CHECK_ISOLATE instead of the more heavy DARTSCOPE for (Closed)

Created:
7 years, 3 months ago by siva
Modified:
7 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use CHECK_ISOLATE instead of the more heavy DARTSCOPE for Dart_HandleFromPersistent and DartHandleFromWeakPersistent. These functions do not allocate any VM handles. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=27535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 3 months ago (2013-09-16 20:43:12 UTC) #1
hausner
lgtm
7 years, 3 months ago (2013-09-16 21:04:04 UTC) #2
siva
7 years, 3 months ago (2013-09-16 21:57:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27535 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698